Skip to content

feat: copy submit pipeline arguments from custom run id #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxy-shpfy merged 1 commit into from
Jan 15, 2026
Merged

feat: copy submit pipeline arguments from custom run id #1623

maxy-shpfy merged 1 commit into from
Jan 15, 2026
+116 −39

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Jan 13, 2026 •
edited
Loading

Description

Closes https://github.com/Shopify/oasis-frontend/issues/421

Enhanced the "Copy from Run" functionality in the SubmitTaskArgumentsDialog component to allow users to copy arguments from a specific run by entering a run ID directly. This improves workflow efficiency by providing an alternative to selecting from the recent runs list.

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Screen Recording 2026-01-12 at 6.41.59 PM.mov (uploaded via Graphite)

  1. Open the task submission dialog
  2. Click on "Copy from Run"
  3. Test entering a valid run ID in the new input field and verify arguments are copied
  4. Test entering an invalid run ID and verify error handling
  5. Verify that selecting from recent runs still works as before
  6. Confirm that copied arguments are merged with existing ones rather than replacing them completely

Additional Comments

The implementation now merges copied arguments with existing ones instead of replacing them entirely, preserving any manually entered values that aren't being overwritten.

This was referenced Jan 13, 2026
Merged
Merged
Merged
Merged
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 13, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy mentioned this pull request Jan 13, 2026
Merged
4 tasks
@maxy-shpfy maxy-shpfy marked this pull request as ready for review January 13, 2026 02:43
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner January 13, 2026 02:43
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from 1078bcd to d4fa437 Compare January 13, 2026 02:48
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch 2 times, most recently from a5d0cd3 to 6f6daa8 Compare January 13, 2026 17:51
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from d4fa437 to aee0385 Compare January 13, 2026 17:51
@maxy-shpfy maxy-shpfy mentioned this pull request Jan 13, 2026
Merged
4 tasks
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from aee0385 to 22badcd Compare January 13, 2026 19:36
camielvs
camielvs reviewed Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we can copy from any run regardless of whether it has anything in common with the current pipeline or not, should we provide some kind of success/fail/info ux to the user?
e.g. a little popup below the copy button that says "x arguments copied", or highlighting the fields that have changed.

Especially in larger lists I found it hard to keep track of what changed and there's not much visual feedback to indicate that the copy was a success (or that nothing was copied if I used an unrelated run id)

@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from 22badcd to bf9c8e9 Compare January 14, 2026 00:39
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 6f6daa8 to 685d821 Compare January 14, 2026 00:39
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 14, 2026

@camielvs added highlights in downstream PR

@maxy-shpfy maxy-shpfy requested a review from camielvs January 14, 2026 00:56
camielvs
camielvs approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from bf9c8e9 to 82c5c67 Compare January 15, 2026 00:49
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 685d821 to 6da60a1 Compare January 15, 2026 00:49
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from 82c5c67 to fb90170 Compare January 15, 2026 01:10
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch 2 times, most recently from 73d1e7e to fc1f770 Compare January 15, 2026 02:53
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from fb90170 to e52e057 Compare January 15, 2026 02:53
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from fc1f770 to 54cfa8a Compare January 15, 2026 08:16
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from e52e057 to e0e0464 Compare January 15, 2026 08:16
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch from 54cfa8a to dc61db2 Compare January 15, 2026 08:19
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from e0e0464 to e49fb9b Compare January 15, 2026 08:19
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_run_arguments_from_recent_run branch 2 times, most recently from 003c33e to c97f936 Compare January 15, 2026 08:22
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from e49fb9b to 746ec3d Compare January 15, 2026 08:23
@maxy-shpfy maxy-shpfy changed the base branch from 01-12-feat_copy_submit_run_arguments_from_recent_run to graphite-base/1623 January 15, 2026 08:30
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from 746ec3d to 63223fa Compare January 15, 2026 08:31
@graphite-app graphite-app bot changed the base branch from graphite-base/1623 to master January 15, 2026 08:32
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_copy_submit_pipeline_arguments_from_custom_run_id branch from 63223fa to 53ab305 Compare January 15, 2026 08:32
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 15, 2026 •
edited
Loading

Merge activity

  • Jan 15, 8:33 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 15, 8:33 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit ab52cf0 into master Jan 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camielvs camielvs camielvs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxy-shpfy @camielvs